Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/issue 27 greenwood build and serve workaround #33

Merged
merged 5 commits into from
Aug 16, 2021
Merged

Bug/issue 27 greenwood build and serve workaround #33

merged 5 commits into from
Aug 16, 2021

Conversation

thescientist13
Copy link
Owner

@thescientist13 thescientist13 commented Aug 13, 2021 •
edited
Loading

Related Issue

resolves #27

Summary of Changes

  1. Add build:pre to mock out node_modules structure for Greenwood
  2. Made all npm scripts default to npm for portability

Notes

  1. Will add windows support in add windows to CI and use cross-env to ensure cross OS portability #34
  2. Will track the odd issue of needing the space to check the Greenwood command 
    process.env.__GWD_COMMAND__ === ' develop'

@thescientist13 thescientist13 added the bug Something isn't working label Aug 13, 2021
@netlify
Copy link

netlify bot commented Aug 13, 2021 •
edited
Loading

✔️ Deploy Preview for awesome-bhaskara-b7d76c ready!

🔨 Explore the source changes: d0861ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/awesome-bhaskara-b7d76c/deploys/6116866400db6900088f50e6

😎 Browse the preview: https://deploy-preview-33--awesome-bhaskara-b7d76c.netlify.app

@thescientist13 thescientist13 merged commit 437091e into master Aug 16, 2021
@thescientist13 thescientist13 deleted the bug/issue-27-greenwood-build-and-serve-workaround branch August 16, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for Greenwood yarn serve and yarn build
1 participant
@thescientist13